fix(cli): avoid Windows shell for mcp dev#2524
Open
Genmin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(cli): avoid Windows shell for mcp dev#2524Genmin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Genmin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Genmin
force-pushed
the
codex/fix-mcp-dev-windows-shell
branch
2 times, most recently
from
de8aa19 to
f351681
Compare
Genmin
force-pushed
the
codex/fix-mcp-dev-windows-shell
branch
from
f351681 to
a176ccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell=Truefrom themcp devinspector subprocess pathnpxexecutable withshutil.which()instead of probing through a shell&and verifies the subprocess receives an argument list without shell dispatchFixes #1257.
Validation
uv run pytest tests/cli -quv run ruff check src/mcp/cli/cli.py tests/cli/test_utils.pyuv run pyright src/mcp/cli/cli.py tests/cli/test_utils.pygit diff --check